Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #13 #14

Merged
merged 7 commits into from
Jun 14, 2024
Merged

fix issue #13 #14

merged 7 commits into from
Jun 14, 2024

Conversation

sigma67
Copy link
Collaborator

@sigma67 sigma67 commented Jun 14, 2024

closes #13

@sigma67
Copy link
Collaborator Author

sigma67 commented Jun 14, 2024

fyi @frostming

[tool.pdm] table is not being removed by pdm if it's empty, i.e. this line does not work for the tool.pdm key itself

https://github.com/pdm-project/pdm/blob/f7787cdda868a8f2d3b0c019964fb141d59cdb26/src/pdm/project/project_file.py#L43

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.13%. Comparing base (dda9492) to head (b36a9ba).

Current head b36a9ba differs from pull request most recent head 41cb1bb

Please upload reports for the commit 41cb1bb to get more accurate results.

Files Patch % Lines
src/pdm_build_locked/command.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #14      +/-   ##
===========================================
- Coverage   100.00%   99.13%   -0.87%     
===========================================
  Files            3        3              
  Lines          109      116       +7     
  Branches        23       25       +2     
===========================================
+ Hits           109      115       +6     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sigma67 sigma67 merged commit d025c55 into main Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

locked extras are not created when pyproject.toml has no project.optional-dependencies section
1 participant