footer section completed #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coding-geek21
requested changes
Dec 26, 2021
There was a problem hiding this comment.
@R-V-Vighnesh Just minor changes to be done... Rest all looks good 👍🏼
views/partial/footer.ejs
Outdated
| <body> | ||
|
|
||
| <!--The text and break tags below are placed just for testing purpose. They can be removed later--> | ||
| <h1>Scroll down to view the footer</h1><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br> |
views/partial/footer.ejs
Outdated
|
|
||
| <div class="footer-left"> | ||
|
|
||
| <img src="public\img\pda-logo.png" alt="logo" class="logo"> |
There was a problem hiding this comment.
Change this line <img src="images\pda-logo.png" alt="logo" class="logo">
Also fix the the logo image... It looks shrinken
|
|
||
| <div class="footer-center-2"> | ||
|
|
||
| <h3>Get in Touch</h3> |
There was a problem hiding this comment.
Place some gap below the title Get in Touch
views/partial/footer.ejs
Outdated
|
|
||
| </div> | ||
| <div class="top_scroll"> | ||
| <span onclick="(function(){window.scrollTo({top: 0,left: 0,behavior: 'smooth'})})();"><i class="fa fa-arrow-circle-up"></i></span> |
There was a problem hiding this comment.
Place this at the end
views/partial/footer.ejs
Outdated
| <title>PDA MIT</title> | ||
| <!-- Pre-build CSS --> | ||
| <!-- Custom CSS --> | ||
| <link rel="stylesheet" href="style.css"> |
There was a problem hiding this comment.
Change this to
<link rel="stylesheet" href="css/footer.css">
|
Snr i have made the required changes in code. Can you check whether this footer is appropriate?
|
top scroll button shifted to bottom spacing increaesed between get in touch heading and contents logo image displayed properly
css file-path updated logo image file-path updated break tags used for testing purpose removed
Looks good jnr 🤩🤩 Great work merging it ✨ |
coding-geek21
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #72
Notes for Reviewer
the footer contains :
teamwork by myself, @bala418 , @Bhuvanaa28
