Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker build #139

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Update docker build #139

merged 3 commits into from
Nov 1, 2024

Conversation

macyabbey
Copy link
Contributor

  • Adds muti-platform support to go commands
  • Changed to three stage build so ui and go build are mostly parallel and final stage does not have any of the files used for building.
  • Tweaked pubish github workflow to minimally publish containers for two platforms, linux/amd64 and linux/arm64

@macyabbey
Copy link
Contributor Author

@daveshanley for your consideration

@daveshanley
Copy link
Member

Would you be able to fix the conflict?

@macyabbey
Copy link
Contributor Author

Would you be able to fix the conflict?

@daveshanley Sure thing - fixed conflict.

Also noticed the runner still had ~300 MB from go that wasn't needed. Down to about ~36 MB on the runner.

@daveshanley
Copy link
Member

I just tried this, 38mb on my machine! woo, nice job, thank you for this Docker kung-fu.

@daveshanley daveshanley merged commit 1ca6f78 into pb33f:main Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release/patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macyabbey @daveshanley