-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quickstart guide for ohttp-relay on basic ubuntu server #90
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some very basic curl requests to make sure their server is receiving well
This is the quickest way for us to meaningfully get off zero. I like it.
Should we strip out some of the details like PORT selection in our .conf files and leave it as they exist here
A concrete tutorial can state its opinion on explicit port definition IMO.
@@ -0,0 +1,92 @@ | |||
# Quickstart ohttp relay | |||
|
|||
We'll demostrate how you can setup an ohttp server on common cloud insfrastructure on something like [](483) using the `ohttp-relay` crate in Payjoin Dev Kit. This should take about 30 minutes. This tutorial assumes you have a basic understanding of the AWS infrastructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry the copy still needs some cleanup. I had started making the guide thinking I would need to make it aws specific but its pretty easy to see that's not necessary.
4b1ba6f
to
6fae84a
Compare
c482eb8
to
67350da
Compare
67350da
to
e8cc194
Compare
|
||
This curl request should occur in 2 stages | ||
1. The proxy CONNECT request that passes through your relay to the `https://payjo.in` directory | ||
2. The GET request on `/ohttp-keys` that will return a binary encoded output | ||
A successful test should return a 200/OK response on both of these steps | ||
|
||
```sh | ||
curl -vk --proxy-insecure --proxy https://{your-relay-public-ip} https://payjo.in/ohttp-keys --output - | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that these keys could change is there a nice way to check and make sure the keys we are receiving are what we expect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As opposed to something like just telling them to verify that the response == some_key_value
e8cc194
to
81541b0
Compare
This issue payjoin/ohttp-relay#37 outlines a need for some documentation for a quickstart guide on a docker server with a nginx proxy. This iteration uses the existing dockerfile with a nginx reverse proxy in front.
81541b0
to
7add53b
Compare
This issue payjoin/ohttp-relay#37 outlines a need for some documentation for a quickstart guide on a docker server with an nginx proxy.
You can take a look at the pretty markdown here https://github.com/benalleng/payjoin.org/blob/ohttp-relay-tutorial/docs/tutorials/quickstart-ohttp-relay.md
Still a WIP as there is still some text i need to cleanup and I have some outstanding questions
A few oustanding questions remain with this guide.
Figure out why my current implementation is not quite working correctlyI think this is ready for some double checks as I am able to proxy to the payjo.in directory successfullycurl -vk --proxy-insecure --proxy https://{you-public-ip} https://payjo.in/ohttp-keys --output -
command does an ok job of ensuring that the proxy successfully connects and is able to then receive data from the payjo.in directoryShould we strip out some of the details like PORT selection in ourA quickstart guide like this is the time to be opinionated.conf
files and leave it as they exist here