Mute videos on iOS devices when tapped #159
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT(paulirish): daniel left this amazing comment on an ios branch commit.. here's that comment:
The change introduces a condition to mute videos when they are played on an iPad or iPhone. Specifically, it adds the parameter
'mute', '1'
to the video URL if the platform is identified as iPad or iPhone. This is achieved using the test/iPad|iPhone|iPod/.test(navigator.platform)
.The purpose is to mute videos automatically on these devices upon tapping based on the findings I mentioned here: 9dfd33a#commitcomment-130244618