Solved another spec race condition with that effects JRuby#134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JRuby CI was intermittently failing in
Cancellation Integration(stdio-native) due to concurrency races in cancellation paths. The failing spec relied on unsynchronized shared state between threads, which is more likely to flake on JRuby / cause issues in production settings though MRI should be safe to do it's thread model.I also found a related runtime race where a cancellable operation could be marked
runningbefore its worker thread was safely published, causing cancellation to miss the thread in rare timing windows.Solution
Queue-based signaling.TransportErrorduring teardown races.CancellableOperationto publishstateandthreadatomically under mutex, so cancellation always sees a consistent state.PromiseandAsyncResponsewith synchronized accessors.kill+ shortjoin) to reduce orphaned worker threads after timeout.