Skip to content

chore(chart legend): convert to typescript #11823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented May 11, 2025

Towards #11719

The following examples are converted:

  • Basic with right aligned legend
  • Bottom aligned legend
  • Responsive bottom-left aligned legend
  • Standalone legend
  • Interactive legend
  • Interactive legend with pie chart
  • Legend tooltips
  • Legend links
  • Legend layout

@patternfly-build
Copy link
Contributor

patternfly-build commented May 11, 2025

@Mash707
Copy link
Contributor Author

Mash707 commented May 11, 2025

@thatblindgeye ready for review.

@Mash707 Mash707 mentioned this pull request May 10, 2025
17 tasks
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment below. The tooltip example is also not working as expected, only the last legend item triggers a tooltip for me. Havent had a chance to investigate but thinking maybe it's due to the single ref being created

@Mash707
Copy link
Contributor Author

Mash707 commented May 14, 2025

I'll look into this.

@Mash707
Copy link
Contributor Author

Mash707 commented May 14, 2025

Havent had a chance to investigate but thinking maybe it's due to the single ref being created

Yup, needed to create ref inside the LegendLabel function.

@thatblindgeye thatblindgeye merged commit 969256b into patternfly:main May 19, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

@Mash707 Mash707 deleted the chart-legend-convert-to-typescript branch May 20, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants