-
Notifications
You must be signed in to change notification settings - Fork 365
chore(chart legend): convert to typescript #11823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(chart legend): convert to typescript #11823
Conversation
Preview: https://patternfly-react-pr-11823.surge.sh A11y report: https://patternfly-react-pr-11823-a11y.surge.sh |
@thatblindgeye ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick comment below. The tooltip example is also not working as expected, only the last legend item triggers a tooltip for me. Havent had a chance to investigate but thinking maybe it's due to the single ref being created
packages/react-charts/src/victory/components/ChartLegend/examples/ChartLegendTooltips.tsx
Outdated
Show resolved
Hide resolved
I'll look into this. |
Yup, needed to create ref inside the LegendLabel function. |
Your changes have been released in:
Thanks for your contribution! 🎉 |
Towards #11719
The following examples are converted: