fix(Table): removed divider for expanded rows #11815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
commented
May 8, 2025
| @@ -29,8 +29,8 @@ | |||
| "clean": "rimraf dist" | |||
| }, | |||
| "devDependencies": { | |||
| "@patternfly/patternfly": "6.3.0-prerelease.6", | |||
| "css": "^3.0.0", | |||
| "@adobe/css-tools": "^4.4.2", | |||
There was a problem hiding this comment.
Context: the original css package was last updated in 2020 and we were getting build errors due to the @starting-style property from Core. This new package is a fork of the original but more up to date.
|
Preview: https://patternfly-react-pr-11815.surge.sh A11y report: https://patternfly-react-pr-11815-a11y.surge.sh |
nicolethoen
reviewed
May 15, 2025
wise-king-sullyman
approved these changes
May 20, 2025
andrew-ronaldson
approved these changes
May 20, 2025
kmcfaul
approved these changes
May 20, 2025
| @@ -1602,11 +1602,10 @@ exports[`Table Collapsible nested table 1`] = ` | |||
| </td> | |||
| </tr> | |||
| <tr | |||
| class="pf-v6-c-table__tr pf-v6-c-table__expandable-row" | |||
There was a problem hiding this comment.
Deprecated table tests/examples looks like it needs a similar update potentially, but I think that's probably fine in a follow up or until someone opens an issue for deprecated specifically.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Jun 4, 2025
* fix(Table): removed divider for expanded rows * Updated snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11812, closes #11807, closes #11808
Table was updated to a more correct logic of applying certain classes from Core as were a few examples updates to show the correct way to set the tables up with those closes.
The animations aspect just needs to have confirmed that accordion, expandable section, and table expansion look good.
Additional issues: