feat(Tabs): added animations #11767
Open
feat(Tabs): added animations #11767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11767.surge.sh A11y report: https://patternfly-react-pr-11767-a11y.surge.sh |
thatblindgeye
requested review from
kaylachumley,
a team,
rebeccaalpert,
wise-king-sullyman and
srambach
and removed request for
a team
thatblindgeye
force-pushed
the
iss11348_tabsAnimation
branch
2 times, most recently
from
c9a3c66 to
0c323e3
Compare
rebeccaalpert
approved these changes
Apr 17, 2025
thatblindgeye
force-pushed
the
iss11348_tabsAnimation
branch
3 times, most recently
from
0cbe199 to
7fc661c
Compare
thatblindgeye
force-pushed
the
iss11348_tabsAnimation
branch
2 times, most recently
from
5b70362 to
c10341f
Compare
|
I do think we should add support for html-only tabs (disabling the animation via a class or setting automatic widths on those two style css), but I don't think we need to block this PR for that. We can do any adjustments in a follow up. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11348
Looks like with the update to Tabs styling, we'll have to make updates in Org for the tabs being used for component pages. If any consumers are using tabs classes similar to how we are in Org (applying the tabs classes to elements rather than using the Tabs components themselves), they will probably run into a similar issue.
I updated and skipped some tests for now. Old tests didn't seem relevant with the unit tests for OverflowTab, and 1 test relies on a potential Core fix and the other was just acting up no matter what I had tried. Basically if there were 2 tests interacting with the OverflowTab, the 1st test would fail to find an item within that overflow menu while the 2nd test worked fine (using the same exact selectors/assertions). Remove the 1st test and suddenly the 2nd (now the 1st) would fail to find the specified overflow item.
Additional issues: