-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(get-started): Updates "about PatternFly" page. #3930
Conversation
bunch of notes/q's:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits.
packages/documentation-site/patternfly-docs/content/get-started/about-patternfly.md
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/about-patternfly.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/about-patternfly.md
Show resolved
Hide resolved
I like the cards. I'm a little confused by the about.md and about-PatternFly.md both? They seem to be the same or very similar? |
@srambach ty for the feedback!!
I've talked to Andrew about this idea some, but I think there's a good opportunity to create an "all components" kind of doc on org (as proposed in patternfly/patternfly-design#1301). This would be a place where we could add higher level component docs (like information about beta components and deprecated components) so that they're more and juxtaposed by the component docs. I think numbers 2 and 3 above could both be moved into that new area, if/when it does come to fruition. But, if they need to be moved in the future, that can be handled in a separate pr! |
<Grid sm={12} md={4} hasGutter> | ||
<Button size="lg" variant="secondary" component="a" href="/get-started/design"> Start designing </Button> | ||
<Button size="lg" variant="secondary" component="a" href="/get-started/develop"> Start developing </Button> | ||
<Button size="lg" variant="secondary" component="a" href="/get-started/contribute/contributing-to-patternfly"> Contribute to PatternFly</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Button size="lg" variant="secondary" component="a" href="/get-started/contribute/contributing-to-patternfly"> Contribute to PatternFly</Button> | |
<Button size="lg" variant="secondary" component="a" href="/get-started/contribute"> Contribute to PatternFly</Button> |
Note to change this if #3926 closes. Could be handled in a followup issue that updates links across the website, assuming there's a few areas that would need this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments/questions, but nothing major.
</CardFooter> | ||
</Card> | ||
<Card isCompact> | ||
<CardTitle className="pf-v5-u-font-size-l"> Follow us on Twitter </CardTitle> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be X now? 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh yes, good catch! It's still Twitter in my head 😅
Actually, since there are a few places across the site that mention Twitter, I'll also open a separate issue to update everywhere else. Going ahead and changing it here, though!
|
||
## Release cadence | ||
|
||
We plan to release a new major version of PatternFly every year. These major releases will be the only releases with planned "breaking" changes that alter core code functionality. Along with each major release, we will provide detailed upgrade guides and codemods to support the work needed to upgrade your products to the latest version of PatternFly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"breaking" changes that alter core code functionality
- since we use "core" as the css repo, should this be something like "breaking changes" that alter the way your code interacts with the PatternFly code
or something like that? Or say PatternFly's API but it's not an API like some may define it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great point! I like that suggestion
|
||
Occasionally, after a component is promoted out of beta, subsequent enhancement requests require the introduction of new CSS class names and React properties. Whenever these enhancements are substantial enough to lead to further component updates (pending testing and feedback), then a beta label is applied to the new class names and properties, as well as relevant examples in the component’s documentation. | ||
|
||
[Learn more about beta components and view a list of current promotion candidates here.](https://github.com/patternfly/patternfly-org/tree/main/beta-component-promotion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh boy, the content at this link could use some updating! 😄
<Grid sm={12} md={4} hasGutter> | ||
<Button size="lg" variant="secondary" component="a" href="/get-started/design"> Start designing </Button> | ||
<Button size="lg" variant="secondary" component="a" href="/get-started/develop"> Start developing </Button> | ||
<Button size="lg" variant="secondary" component="a" href="/get-started/contribute"> Contribute to PatternFly</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link seems to be broken. I think it's this one get-started/contribute/contributing-to-patternfly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm so this pr, which will probably be merged at the same time as this one, changes the url to be /get-started/contribute. Do you think I should keep the link as get-started/contribute/contributing-to-patternfly in this pr and just do a follow up once these are all merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge them all! lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟 Changes look good!
- @patternfly/[email protected] - @patternfly/[email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet moves!
Closes #3897