-
Notifications
You must be signed in to change notification settings - Fork 8
feat(SectionGallery): add section gallery components #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One question I have is how we want to specify exports for things like |
This will be easier to test out after #49 merges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests for anything that we don't plan on replacing ASAP?
I'd be alright with that being done in a followup though.
I think maybe move that to a follow up, I'm currently unsure how to go about testing things that live in the code fences? Maybe can pull the functions into a separate file |
Yeah the stuff in the astro files I'm also not sure of how to test yet, and that's a broader thing we need to figure out. I'll make an issue for that if we don't already have one. At the moment I think we're just calling all the React/TS stuff being tested good enough, but like I said I would be fine with you doing that under a followup if you want to get this issue closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions about types and image behavior - otherwise this looks good to me. :) Feel free to ignore them if they're dumb n00b comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @kmcfaul
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds suite of SectionGallery components, loosely based on current org counterparts.
I included two test md/jsx files to showcase the updated landing page structure. Landing pages must have an
id
oflanding
, asection
, and atitle
for display.sortValue
can be used to control where in the nav list the landing page is shown. The component data file (compared to org) is now JSX and contains JSX directly instead of needing to parse JSON into JSX.I also updated the
[...tab].astro
,[...page].astro
, andlanding.astro
to only match relevant routes instead of mapping the whole collection. Now landing.astro will only match for pages whose id is "landing", tab.astro will only match for pages with a tab, and page.astro should match everything except for landings (component tab pages should still be rerouted to tab.astro).Once the examples/JS in mds is rendering properly I can revisit to test SectionGallery, but otherwise I did test this locally by inserting the component directly into landing.astro.