feat(CodeBlockMessage/Message): Add expandable code block #556
+178
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://chatbot-pr-chatbot-556.surge.sh A11y report: https://chatbot-pr-chatbot-556-a11y.surge.sh |
rebeccaalpert
force-pushed
the
code-editor-expandable
branch
6 times, most recently
from
54818d3 to
93da6cf
Compare
rebeccaalpert
force-pushed
the
code-editor-expandable
branch
from
93da6cf to
30e6135
Compare
rebeccaalpert
changed the title
edonehoo
requested changes
May 21, 2025
packages/module/src/Message/CodeBlockMessage/CodeBlockMessage.tsx
Outdated
Show resolved
Hide resolved
|
All set @edonehoo; thank you! |
edonehoo
approved these changes
May 21, 2025
kaylachumley
requested changes
May 21, 2025
packages/module/src/Message/CodeBlockMessage/CodeBlockMessage.scss
Outdated
Show resolved
Hide resolved
packages/module/src/Message/CodeBlockMessage/CodeBlockMessage.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Erin Donehoo <[email protected]>
rebeccaalpert
force-pushed
the
code-editor-expandable
branch
from
8e5df16 to
c977224
Compare
|
Thanks @kaylachumley! All set. |
|
Looks great; Thank you for adding this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a request from RHDH product manager - wanted to be able to make code blocks optionally expandable. They were fine with having it applied to all code blocks in message - they envision having it applied to all user messages by default.
Kayla wanted the truncated toggle applied by default - it sounds like design will have general PF migrate in that direction soon.
Docs: https://chatbot-pr-chatbot-556.surge.sh/patternfly-ai/chatbot/messages (go to user or bot message and select "expandable code" option from dropdown.)