Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad comma in maxymiser addition #242

Merged
merged 1 commit into from
Feb 6, 2025
+11 −1
Merged

Fix bad comma in maxymiser addition #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/entities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6450,7 +6450,7 @@ module.exports = [
{
name: 'Maxymiser',
category: 'analytics',
domains: ['*.maxymiser.net, maxymiser.hs.llnwd.net'],
domains: ['*.maxymiser.net', 'maxymiser.hs.llnwd.net'],
},
{
name: 'McAffee',
Expand Down
10 changes: 10 additions & 0 deletions lib/entities.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,14 @@ describe('Entities', () => {
}
}
})

it('should not have commas within a domain', () => {
for (const entity of entities) {
for (const domain of entity.domains) {
// A domain can be `*.maxymiser.net` or `maxymiser.hs.llnwd.net`
// A domain can't be `*.maxymiser.net, maxymiser.hs.llnwd.net`
expect(domain).toEqual(expect.not.stringContaining(','))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expect(domain).not.toContain(',') was just too simple huh ;)

}
}
})
})