Update Osano references #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks very much @mpchadwick and apologies for the very late reply I missed this! Let's just add these domains then instead of replacing :) |
|
Done! |
patrickhulce
approved these changes
Feb 6, 2025
|
thanks very much @mpchadwick ! |
|
🎉 This PR is included in version 0.26.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - I'm a big fan of this project. I was looking for some data on Osano and noticed that, while there are entries in
2024-10-01-observed-domains.jsonfor some of their domains, there is nothing in2024-10-01-entity-scripting.json. I assume that the reason is because the domains listed inentities.jsdon't match the domains they are currently using. I'm thinking these changes will fix this issue, although I'm not sure how to test that myself