Skip to content

Commit

Permalink
fix(entities): remove inadvertent comma in maxymiser domain (#242)
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirish authored Feb 6, 2025
1 parent 021299a commit 9e631b6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion data/entities.js
Original file line number Diff line number Diff line change
Expand Up @@ -6450,7 +6450,7 @@ module.exports = [
{
name: 'Maxymiser',
category: 'analytics',
domains: ['*.maxymiser.net, maxymiser.hs.llnwd.net'],
domains: ['*.maxymiser.net', 'maxymiser.hs.llnwd.net'],
},
{
name: 'McAffee',
Expand Down
10 changes: 10 additions & 0 deletions lib/entities.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,14 @@ describe('Entities', () => {
}
}
})

it('should not have commas within a domain', () => {
for (const entity of entities) {
for (const domain of entity.domains) {
// A domain can be `*.maxymiser.net` or `maxymiser.hs.llnwd.net`
// A domain can't be `*.maxymiser.net, maxymiser.hs.llnwd.net`
expect(domain).toEqual(expect.not.stringContaining(','))
}
}
})
})

0 comments on commit 9e631b6

Please sign in to comment.