Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test, etc. #39

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

nstarman
Copy link
Contributor

No description provided.

tests/test_lora.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
quax/_core.py Outdated Show resolved Hide resolved
@nstarman nstarman force-pushed the regression_test branch 2 times, most recently from a9612b9 to cc10db6 Compare January 31, 2025 17:01
@nstarman
Copy link
Contributor Author

nstarman commented Jan 31, 2025

OMFG. I can't get the leaked tracers to happen in #44 or on my computer (varying Python version and test order), but they're cropping up again here

@nstarman nstarman force-pushed the regression_test branch 3 times, most recently from 1e8dc02 to 761e69a Compare January 31, 2025 17:29
@nstarman nstarman mentioned this pull request Jan 31, 2025
@patrick-kidger
Copy link
Owner

Haha, oh no! Can you rebase this on latest and then let's see where we're at?

Signed-off-by: Nathaniel Starkman <[email protected]>
style(jax.extend): alias to jex

Signed-off-by: Nathaniel Starkman <[email protected]>
@nstarman
Copy link
Contributor Author

nstarman commented Feb 2, 2025

@patrick-kidger, done!

@nstarman nstarman mentioned this pull request Feb 2, 2025
@@ -48,6 +48,9 @@ select = ["E", "F", "I001"]
ignore = ["E402", "E721", "E731", "E741", "F722"]
fixable = ["I001", "F401"]

[tool.ruff.lint.flake8-import-conventions.extend-aliases]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh now this is a cool rule that I didn't know existed!

@patrick-kidger patrick-kidger merged commit 3b50d2d into patrick-kidger:main Feb 4, 2025
3 checks passed
@patrick-kidger
Copy link
Owner

Alright, LGTM! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants