Stackless, redux #38
Open
Stackless, redux #38
+100
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pytest tests` passes with these changes
Signed-off-by: Nathaniel Starkman <[email protected]>
nstarman
force-pushed
the
stackless-redux
branch
5 times, most recently
from
4fbc627 to
c0c7530
Compare
Signed-off-by: Nathaniel Starkman <[email protected]>
Signed-off-by: Nathaniel Starkman <[email protected]>
nstarman
force-pushed
the
stackless-redux
branch
from
8d3599d to
4e79652
Compare
|
Nice! Thank you for putting this together. Do you have an idea how to tackle #37 (comment) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @patrick-kidger @mattjj!
I cherry-picked @mattjj's commits, fixed the CI, and made the suggested refactor.
I'm happy to push these fixes as a PR to @mattjj's branch instead of this PR.
The changes in jax also require python 3.10+