Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I ran into a few problems trying to run the custom rules tutorial:
1
Encountered
TypeError: '<' not supported between instances of 'Dimension' and 'Dimension'
as JAX (v0.4.34 in my env.tries to sort pytrees dictionary keys when flattening. Added methods to allow comparingDimension
using theirname
attribute.2
Noticed that
does not elevate
x.array
to the power ofy
. (incidentally fixes an inconsistent output)3
Noticed that
from jaxtyping import ArrayLike # https://github.com/patrick-kidger/quax
does not use the correct URL.Are you ok with the proposed changes?
Vadim