Check finite input #130
Merged
Check finite input #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
patrick-kidger
pushed a commit
that referenced
this pull request
Feb 9, 2025
* check for non-finite inputs if solution has NaN or inf * remove private import --------- Co-authored-by: Johanna Haffner <[email protected]>
patrick-kidger
pushed a commit
that referenced
this pull request
Feb 23, 2025
* check for non-finite inputs if solution has NaN or inf * remove private import --------- Co-authored-by: Johanna Haffner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described #81. (Came across this problem too.)
Will overwrite
RESULTS.singularwith a newRESULTS.nonfinite_inputif the input is indeed nonfinite.