Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a preconditioner example #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vboussange
Copy link

@vboussange vboussange commented Dec 19, 2024

Hey there, here is an attempt to make an example for the use of a preconditioner, as discussed in #8. I implemented a simple Jacobi preconditioner, which does not seem to provide much advantage though. @patrick-kidger Any idea of a low hanging fruit solution to have a nicer demonstration of the use of preconditioners?

I personally would love to see an example with a hand crafted preconditioner such as the one proposed, and a more involved using e.g.pyamg preconditioning capability, with a possible pure_callback call.

@patrick-kidger
Copy link
Owner

In terms of the implementation, I like this example! It's short and easy to follow.

(Nit: jr.PRNGKey -> jr.key; the former has been replaced with the latter.)

Also tagging @frederic-bender from #8, as I don't have strong feelings about what would make for a stronger example of preconditioning. (I note that the Julia folks also only consider a very simple example.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants