Remove a no-longer-valid criteria in honoring the response header #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader We have made the decision that when the topics are empty, we'd still send the header. The "would have included the header if it wasn't empty" is obsolete.
Donabbas
approved these changes
Jul 27, 2024
tempid000
suggested changes
Oct 30, 2024
| @@ -69,7 +69,7 @@ The topics will be inferred by the browser. The browser will leverage a classifi | |||
| * The request header will be sent on document requests via specifying an attribute: `<iframe src=[url] browsingtopics></iframe>`, or via the equivalent IDL attribute: `iframe.browsingTopics = true`. | |||
| * Redirects will be followed, and the topics sent in the redirect request will be specific to the redirect url. | |||
| * The request header will not modify state for the caller unless there is a corresponding response header. That is, the topic of the page won't be considered observed, nor will it affect the user's topic calculation for the next epoch. | |||
| * The response header will only be honored if the corresponding request included the topics header (or would have included the header if it wasn't empty). | |||
| * The response header will only be honored if the corresponding request included the topics header (i.e. was eligible for topics). | |||
| @@ -69,7 +69,7 @@ The topics will be inferred by the browser. The browser will leverage a classifi | |||
| * The request header will be sent on document requests via specifying an attribute: `<iframe src=[url] browsingtopics></iframe>`, or via the equivalent IDL attribute: `iframe.browsingTopics = true`. | |||
| @@ -69,7 +69,7 @@ The topics will be inferred by the browser. The browser will leverage a classifi | |||
| * The request header will be sent on document requests via specifying an attribute: `<iframe src=[url] browsingtopics></iframe>`, or via the equivalent IDL attribute: `iframe.browsingTopics = true`. | |||
| * Redirects will be followed, and the topics sent in the redirect request will be specific to the redirect url. | |||
| * The request header will not modify state for the caller unless there is a corresponding response header. That is, the topic of the page won't be considered observed, nor will it affect the user's topic calculation for the next epoch. | |||
| * The response header will only be honored if the corresponding request included the topics header (or would have included the header if it wasn't empty). | |||
| * The response header will only be honored if the corresponding request included the topics header (i.e. was eligible for topics). | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made the decision that when the topics are empty, we'd still send the header. The "would have included the header if it wasn't empty" is obsolete.