Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: disallow fenced frames setting contextId/filteringIdMaxBytes. #151

Merged

Conversation

blu25
Copy link
Contributor

@blu25 blu25 commented Jul 29, 2024

sharedStorage.run() accepts a privateAggregationConfig(https://patcg-individual-drafts.github.io/private-aggregation-api/#dom-sharedstoragerunoperationmethodoptions-privateaggregationconfig) field, which allows
settings to be passed in to be used when sending Private Aggregation reports. However, this can be used from within a fenced frame to exfiltrate information. Because of that, these fields must be completely disabled inside of fenced frames.

Note: The aggregationCoordinatorOrigin field is needed for to select the coordinator, which is a major part of the functionality of the API. The long-term goal is to disallow setting privateAggregationConfig altogether inside of fenced frames. But for now, the usability hit is way too large to disable all of the fields. This will be revisited in the future when there are alternate ways to set the coordinator origin.


Preview | Diff

Copy link
Collaborator

@alexmturner alexmturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally looks good! Just some nits

@alexmturner alexmturner merged commit 9108e9b into patcg-individual-drafts:main Aug 29, 2024
1 check passed
github-actions bot added a commit that referenced this pull request Aug 29, 2024
…151)

SHA: 9108e9b
Reason: push, by alexmturner

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants