Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Change preview.yml to validate.yml #149

Conversation

dmcardle
Copy link
Contributor

@dmcardle dmcardle commented Jul 26, 2024

This change converts the "Preview" job into a "Validate" job. It still runs for every PR, but it does not deploy to the gh-pages branch.

Fixes #148


Preview | Diff

This change converts the "Preview" job into a "Validate" job. It still
runs for every PR, but it does not deploy to the gh-pages branch.

Fixes patcg-individual-drafts#148
@dmcardle
Copy link
Contributor Author

Added a temporary change to spec.bs to exercise the "Validate" job and saw what I expected:

Deploy to GitHub pages
  Skipped.

I'll drop that temp commit now.

@dmcardle dmcardle force-pushed the dmcardle-preview-to-validate-job branch from 7f5429c to 1dd7587 Compare July 26, 2024 15:38
@dmcardle
Copy link
Contributor Author

@alexmturner Low priority — PTAL when you get a chance.

@alexmturner
Copy link
Collaborator

LGTM!

@alexmturner alexmturner merged commit b87549a into patcg-individual-drafts:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Preview" job fails for users without write access
2 participants