Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe per-calling-API contribution count limits in explainer #138

Conversation

dmcardle
Copy link
Contributor

@dmcardle dmcardle commented Jul 1, 2024

This PR corresponds to

@alexmturner PTAL!


Preview | Diff

Copy link
Collaborator

@alexmturner alexmturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dan! Pretty much looks good -- just some nits

@dmcardle dmcardle force-pushed the dmcardle-protected-audience-100-contribs branch from 075b203 to 2a6d418 Compare July 8, 2024 19:48
@dmcardle
Copy link
Contributor Author

dmcardle commented Jul 8, 2024

Hey @alexmturner, PTAL again!

@dmcardle dmcardle force-pushed the dmcardle-protected-audience-100-contribs branch from 2a6d418 to 9c32995 Compare July 25, 2024 16:41
@dmcardle dmcardle changed the title Describe caller-specific contribution limits in explainer Describe per-calling-API contribution count limits in explainer Jul 25, 2024
@alexmturner alexmturner merged commit a53a027 into patcg-individual-drafts:main Aug 23, 2024
aarongable pushed a commit to chromium/chromium that referenced this pull request Aug 27, 2024
This CL implements the logic for limiting Protected Audience callers to
100 contributions per report. Shared Storage callers are not affected.

The new behavior is gated behind a feature flag that is disabled by
default.

* Explainer change:
  patcg-individual-drafts/private-aggregation-api#138

* Spec change:
  patcg-individual-drafts/private-aggregation-api#150

Bug: 360160864
Change-Id: I14cd4087986a8ecb70e60701d56fac6d25135a53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5743397
Commit-Queue: Dan McArdle <[email protected]>
Reviewed-by: Alex Turner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1347486}
dmcardle added a commit to dmcardle/private-aggregation-api that referenced this pull request Aug 28, 2024
github-actions bot added a commit to dmcardle/private-aggregation-api that referenced this pull request Aug 28, 2024
patcg-individual-drafts#138)

SHA: ef934e0
Reason: push, by dmcardle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants