-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe per-calling-API contribution count limits in explainer #138
Merged
alexmturner
merged 1 commit into
patcg-individual-drafts:main
from
dmcardle:dmcardle-protected-audience-100-contribs
Aug 23, 2024
Merged
Describe per-calling-API contribution count limits in explainer #138
alexmturner
merged 1 commit into
patcg-individual-drafts:main
from
dmcardle:dmcardle-protected-audience-100-contribs
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmturner
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Dan! Pretty much looks good -- just some nits
075b203
to
2a6d418
Compare
Hey @alexmturner, PTAL again! |
2a6d418
to
9c32995
Compare
alexmturner
approved these changes
Aug 21, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 27, 2024
This CL implements the logic for limiting Protected Audience callers to 100 contributions per report. Shared Storage callers are not affected. The new behavior is gated behind a feature flag that is disabled by default. * Explainer change: patcg-individual-drafts/private-aggregation-api#138 * Spec change: patcg-individual-drafts/private-aggregation-api#150 Bug: 360160864 Change-Id: I14cd4087986a8ecb70e60701d56fac6d25135a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5743397 Commit-Queue: Dan McArdle <[email protected]> Reviewed-by: Alex Turner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1347486}
dmcardle
added a commit
to dmcardle/private-aggregation-api
that referenced
this pull request
Aug 28, 2024
github-actions bot
added a commit
to dmcardle/private-aggregation-api
that referenced
this pull request
Aug 28, 2024
patcg-individual-drafts#138) SHA: ef934e0 Reason: push, by dmcardle Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corresponds to
@alexmturner PTAL!
Preview | Diff