Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos in README.md and spec.bs #137

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

dmcardle
Copy link
Contributor

@dmcardle dmcardle commented Jul 1, 2024

Copy link
Collaborator

@alexmturner alexmturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@dmcardle
Copy link
Contributor Author

dmcardle commented Jul 1, 2024

No prob!

Looks like the Preview job is unhappy... transient failure or permissions issue? https://github.com/patcg-individual-drafts/private-aggregation-api/actions/runs/9750422730/job/26909820186?pr=137#step:3:940

@alexmturner
Copy link
Collaborator

I just tested in #139 so I think it's a permissions issue. I think we might need to add you to the patcg-individual-drafts org to fix it?

But for now, I'll just merge given the change to spec.bs is so small.

@alexmturner alexmturner merged commit 321eba1 into patcg-individual-drafts:main Jul 2, 2024
1 check failed
github-actions bot added a commit that referenced this pull request Jul 2, 2024
SHA: 321eba1
Reason: push, by alexmturner

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants