Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: minor fixes #130

Merged
merged 3 commits into from
May 17, 2024
Merged

Spec: minor fixes #130

merged 3 commits into from
May 17, 2024

Conversation

alexmturner
Copy link
Collaborator

@alexmturner alexmturner commented May 6, 2024

Makes some minor improvements to the spec, primarily in improving hyperlinks when indexing into objects, using a range and fixing a stale monkeypatched algorithm name. This should not affect any behavior (just description).


Preview | Diff

Makes some minor improvements to the explainer, primarily in improving
hyperlinks when indexing into objects and using a range.
@alexmturner
Copy link
Collaborator Author

Low priority: @linnan-github @arichiv, could you PTAL? Thanks!

Copy link

@arichiv arichiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nits

@alexmturner
Copy link
Collaborator Author

@linnan-github, friendly ping :)

@alexmturner
Copy link
Collaborator Author

Also fyi -- fixed links to a monkeypatched algorithm that was renamed.

@alexmturner
Copy link
Collaborator Author

Thanks!

@alexmturner alexmturner merged commit ed0420f into main May 17, 2024
1 check passed
@alexmturner alexmturner deleted the minor-fixes branch May 17, 2024 19:37
github-actions bot added a commit that referenced this pull request May 17, 2024
SHA: ed0420f
Reason: push, by alexmturner

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants