Spec: minor fixes #122
Merged
Spec: minor fixes #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some minor issues discovered in the spec, also adds some Issue comments to track some potential future clean ups.
alexmturner
commented
Mar 28, 2024
| Web Platform Design Principles</a>, we should consider switching `long` to | ||
| `[EnforceRange] long long`. | ||
|
|
||
| Issue: {{PrivateAggregation/enableDebugMode(options)}}'s argument should not |
There was a problem hiding this comment.
Note that fixing this to match the implementation (i.e. an optional argument with no default value) causes validation issues in the spec. So, we might need to change it by making debugKey optional instead.
|
@linnan-github, could you PTAL? Thanks! |
linnan-github
approved these changes
Mar 29, 2024
|
Thanks again! |
github-actions bot
added a commit
that referenced
this pull request
Mar 29, 2024
SHA: e4ab73c Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some minor issues discovered in the spec where behavior did not exactly align with the implementation. Also adds some Issue comments to track some potential future improvements (e.g. aligning error types).
Preview | Diff