Frontend fixes for #1113 #1200
Open
Frontend fixes for #1113 #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert max value limitation. Negative stock values are allowed/expected behavior in some circumstances.
Add confirmation dialog before allowing user to create negative stock levels. Should close issue partkeepr#1113.
Codecov Report
@@ Coverage Diff @@
## master #1200 +/- ##
=========================================
Coverage 36.87% 36.87%
Complexity 1803 1803
=========================================
Files 258 258
Lines 5763 5763
=========================================
Hits 2125 2125
Misses 3638 3638 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend fixes for issue #1113:
Per discussions on the bug tracker negative stock levels are an intended feature covering a common use case, so this should close the issue.
Happy to hear suggestions for improvements to the warning text.
Tested via Chrome devtools but I could not get the docker dev image working to build and test.