don't autosearch octo for empty name #1172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Save OctoPart API credits by not auto-searching for empty names.
Currently, when the "Octopart..." button is pressed in the "Add Part" window, an automatic query is performed with the value of the "Name" field. This happens even if the user haven't inputted anything into the "Name" field yet, most likely with the intention of doing it in the "Octopart Search" window itself. This effectively wastes the
partkeepr.octopart.limitnumber of credits on running an effectively useless query. Changes in this PR prevent auto-running empty queries (but do not prevent one from manually running them from the "Octopart Search" window itself by pressing "Enter" in case one might for some weird reason desire to).