Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default footprint setup #1167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

h0m3us3r
Copy link

Fix for the initial setup's footprint database initialization.

Changes this:

To this:

Main fix is in FootprintSetupService.php and FootprintCategory.php.
Docker's dump.sql is updated as well, but I have no idea if that's actually necessary or it is somehow auto-generated.

@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #1167 (34c5da8) into master (9b15674) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1167      +/-   ##
============================================
- Coverage     37.09%   36.86%   -0.23%     
- Complexity     1798     1804       +6     
============================================
  Files           258      258              
  Lines          5729     5764      +35     
============================================
  Hits           2125     2125              
- Misses         3604     3639      +35     
Impacted Files Coverage Δ Complexity Δ
...Keepr/FootprintBundle/Entity/FootprintCategory.php 77.77% <0.00%> (-9.73%) 9.00 <1.00> (+1.00) ⬇️
...pr/OctoPartBundle/Controller/DefaultController.php 0.00% <0.00%> (ø) 5.00 <0.00> (+1.00)
...tKeepr/OctoPartBundle/Services/OctoPartService.php 0.00% <0.00%> (ø) 7.00 <4.00> (+4.00)
...epr/SetupBundle/Services/FootprintSetupService.php 0.00% <0.00%> (ø) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a9d1a...34c5da8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants