-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Features #341 / #404 #1127
base: master
Are you sure you want to change the base?
Conversation
Implements the feature described in issue partkeepr#341 / partkeepr#404 (related / duplicates) This simply adds a check to the report calculation which takes the packagingUnit into account. If the part count (so the missing parts which have to be ordered) is not larger than the packagingUnit of the part distributor, that distributor is omitted (by the continue keyword).
Codecov Report
@@ Coverage Diff @@
## master #1127 +/- ##
=========================================
Coverage 37.09% 37.09%
Complexity 1798 1798
=========================================
Files 258 258
Lines 5729 5729
=========================================
Hits 2125 2125
Misses 3604 3604 Continue to review full report at Codecov.
|
See my comment on the other issue. I will have a look at things soon. |
This should avoid that the calculated price does not use the lowest price per item available while ignoring the minimum order volume. The following case from #404 is now a problem as no distributor will be found at all:
If all offers by potential distributors are sorted out, no bumping can happen. Additionally, this PR is related to issue #1133. We might need to round up the amount to the next full size of the package. |
I agree. If it is decided that this is the way package sizes should be dealt with, Partkeepr should calculate the lowest possible price using the following rules:
|
Implements the feature described in issue(s) #341 / #404 (related / duplicates)
This simply adds a check to the report calculation (frontend JavaScript) which takes the packagingUnit into account.
If the part count (so the missing parts which have to be ordered) is not larger than the packagingUnit of the part distributor, that distributor is omitted (by the continue keyword).