Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Kokkos 4.5 #1216

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Move to Kokkos 4.5 #1216

merged 3 commits into from
Dec 12, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Dec 11, 2024

PR Summary

On Cray HPC machines with GPU direct I was running into Invalid count errors with MPI_Isend on at least the fine_advection example. This appears to be fixed with the Kokkos 4.5 release.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

Copy link
Collaborator

@bprather bprather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can verify KHARMA also does not work when compiled with Parthenon develop + 4.4.01 but does with 4.5.00+. Same Invalid count error, which I'd seen before when upgrading Parthenon & Kokkos. Glad the current release fixes it.

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brryan brryan enabled auto-merge (squash) December 12, 2024 19:13
@brryan brryan mentioned this pull request Dec 12, 2024
10 tasks
@brryan brryan merged commit 89099e3 into develop Dec 12, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants