Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with uninitialized input parameter block data #1215

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Dec 6, 2024

PR Summary

Downstream we were finding input parameter hash mismatch errors when running with multiple MPI ranks on some problems. It turns out this was because we were using an input parameter block with no actual parameters belonging to that block. In this case, the max_len_parname and max_len_parvalue fields for the input block (which are checked during input parameter hashing) are uninitialized. This is a simple fix that solves the downstream issue.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@brryan brryan added the bug Something isn't working label Dec 6, 2024
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch!

@brryan brryan enabled auto-merge (squash) December 6, 2024 15:05
@brryan brryan merged commit 75ec2e2 into develop Dec 6, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants