Fix issue with uninitialized input parameter block data #1215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Downstream we were finding input parameter hash mismatch errors when running with multiple MPI ranks on some problems. It turns out this was because we were using an input parameter block with no actual parameters belonging to that block. In this case, the
max_len_parname
andmax_len_parvalue
fields for the input block (which are checked during input parameter hashing) are uninitialized. This is a simple fix that solves the downstream issue.PR Checklist