Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fall back to Kokkos::sort #1207

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

WIP: Fall back to Kokkos::sort #1207

wants to merge 13 commits into from

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Nov 8, 2024

PR Summary

In the past we did not use Kokkos::sort in favor of thrust::sort, std::sort, or failing, but with Kokkos 4.4 (#1191) Kokkos::sort should now support the custom comparator-based sorting we require.

In the past, performance of Kokkos::sort has been suboptimal. Probably worth checking to see if we should provide more specializations beyond thrust for CUDA, or if we can get rid of thrust while maintaining performance.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files
  • Merge Update Kokkos version to 4.4.1 #1191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant