Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In the past we did not use
Kokkos::sort
in favor ofthrust::sort
,std::sort
, or failing, but with Kokkos 4.4 (#1191)Kokkos::sort
should now support the custom comparator-based sorting we require.In the past, performance of
Kokkos::sort
has been suboptimal. Probably worth checking to see if we should provide more specializations beyondthrust
for CUDA, or if we can get rid ofthrust
while maintaining performance.PR Checklist