Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Document that more EvolutionDriver functions are overridable #1158

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

bprather
Copy link
Collaborator

@pgrete brings up the excellent point we should mention which functions are available to override in EvolutionDriver now in the docs. There's even a quite convenient place to do so, so here's that.

Also previous PR had some tests failing, so this can serve to check whether those were just the AMD CI issues, or something substantial. (I can't imagine marking a method virtual in a class with no children could have broken anything though?)

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@pgrete pgrete enabled auto-merge (squash) August 26, 2024 07:27
@pgrete pgrete merged commit 7529be3 into develop Aug 26, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants