Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI on AMD GPUs #1117

Merged
merged 11 commits into from
Jul 4, 2024
Merged

Add CI on AMD GPUs #1117

merged 11 commits into from
Jul 4, 2024

Conversation

pgrete
Copy link
Collaborator

@pgrete pgrete commented Jun 18, 2024 •
edited
Loading

PR Summary

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@pgrete pgrete added enhancement New feature or request testing labels Jun 18, 2024
@pgrete pgrete enabled auto-merge (squash) July 3, 2024 12:27
@pgrete pgrete disabled auto-merge July 3, 2024 12:27
@pgrete pgrete changed the title WIP Add CI on AMD GPUs Add CI on AMD GPUs Jul 3, 2024
@pgrete
Copy link
Collaborator Author

pgrete commented Jul 3, 2024

Alright, this is working and ready for review.
The new extended tests on AMD are not triggered yet (will only happens once the pipeline is in develop), but I confirmed directly on the machine that they run and pass.
Eventually, I also want to move the Cuda and host tests to the new machine, but given that the old pipelines work it doesn't have a super high priority right now.

pgrete
pgrete commented Jul 3, 2024
View reviewed changes
tst/regression/utils/test_case.py
self.parameters.parthenon_path = os.path.join(
parthenon_path[:idx], "parthenon"
)
self.parameters.parthenon_path = parthenon_path[: idx + 10]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this fixes an edge case where the path would be wrong if parthenon is checked out to /parthenon

pdmullen
pdmullen approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@pdmullen pdmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgrete pgrete mentioned this pull request Jul 3, 2024
Closed
8 tasks
@pgrete pgrete merged commit 2e0e981 into develop Jul 4, 2024
53 checks passed
@pgrete pgrete deleted the pgrete/ci-amd branch July 4, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmullen pdmullen pdmullen approved these changes

@lroberts36 lroberts36 lroberts36 approved these changes

@BenWibking BenWibking BenWibking approved these changes

@Yurlungur Yurlungur Awaiting requested review from Yurlungur

@bprather bprather Awaiting requested review from bprather

Assignees
No one assigned
Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgrete @BenWibking @lroberts36 @pdmullen