Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sparsity to vector wave equation test #1103

Merged
merged 22 commits into from
Nov 12, 2024
Merged

Add sparsity to vector wave equation test #1103

merged 22 commits into from
Nov 12, 2024

Conversation

lroberts36
Copy link
Collaborator

@lroberts36 lroberts36 commented Jun 12, 2024 •
edited by brryan
Loading

PR Summary

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

lroberts36
lroberts36 commented Jun 12, 2024
View reviewed changes
src/parthenon_manager.cpp Outdated Show resolved Hide resolved
lroberts36
lroberts36 commented Jun 12, 2024
View reviewed changes
src/parthenon_manager.cpp Outdated Show resolved Hide resolved
@lroberts36 lroberts36 mentioned this pull request Jun 13, 2024
Merged
12 tasks
@lroberts36 lroberts36 changed the base branch from lroberts36/add-vector-wave-test to develop June 17, 2024 19:13
@lroberts36 lroberts36 mentioned this pull request Oct 17, 2024
Open
12 tasks
@brryan brryan changed the title WIP: Add sparsity to vector wave equation test Add sparsity to vector wave equation test Nov 6, 2024
brryan
brryan approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Yurlungur
Yurlungur approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pgrete
pgrete approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just some nice-to-have/non-blocking doc comments)

example/fine_advection/advection_package.cpp Show resolved Hide resolved
example/fine_advection/advection_package.cpp Show resolved Hide resolved
example/fine_advection/advection_package.cpp Outdated Show resolved Hide resolved
example/fine_advection/advection_package.hpp Outdated Show resolved Hide resolved
example/fine_advection/parthenon_app_inputs.cpp Outdated Show resolved Hide resolved
@lroberts36 lroberts36 enabled auto-merge November 12, 2024 20:23
@lroberts36 lroberts36 merged commit b437013 into develop Nov 12, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrete pgrete pgrete approved these changes

@brryan brryan brryan approved these changes

@Yurlungur Yurlungur Yurlungur approved these changes

@pdmullen pdmullen Awaiting requested review from pdmullen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lroberts36 @Yurlungur @brryan @pgrete