Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send batched events in smoke test #29

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Send batched events in smoke test #29

merged 2 commits into from
Jul 17, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Jul 14, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@trueleo
Copy link
Contributor Author

trueleo commented Jul 14, 2023

I have read the CLA Document and I hereby sign the CLA

@trueleo
Copy link
Contributor Author

trueleo commented Jul 14, 2023

recheck

github-actions bot added a commit that referenced this pull request Jul 14, 2023
@github-actions
@trueleo has signed the CLA in #29
d222842
nitisht
nitisht requested changes Jul 16, 2023
View reviewed changes
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is passing for the release v0.5.0 - We expect that it should fail there due to the event issue we saw.

@trueleo
Copy link
Contributor Author

trueleo commented Jul 17, 2023

This is passing for the release v0.5.0 - We expect that it should fail there due to the event issue we saw.

Adding check for it as a unit test on main, seems like a better place for it. To make this integration test fail on 0.5.0, I'll have to change it to send batched event before single events.

parseablehq/parseable#454

@nitisht
Copy link
Member

nitisht commented Jul 17, 2023

Unit test is fine, but we need change what ever is needed here as well

@trueleo trueleo merged commit 0c3e1f3 into parseablehq:main Jul 17, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitisht nitisht nitisht requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trueleo @nitisht