-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LB timeout in QueryServer
#893
Open
vishalkrishnads
wants to merge
14
commits into
parseablehq:main
Choose a base branch
from
vishalkrishnads:keep-alive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
requested review from
parmesant and
nikhilsinhaparseable
and removed request for
parmesant
August 20, 2024 07:52
nitisht
reviewed
Aug 23, 2024
nitisht
reviewed
Aug 23, 2024
vishalkrishnads
changed the title
Configured keep alive for
Fix LB timeout in Aug 23, 2024
QueryServer
QueryServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The query server takes quite a while to process incoming requests. But, most load balancers timeout before the computation can be completed.
As a temporary fix, this PR configures the query handler to send a one byte HTTP 202 response after waiting for
P_PROXY_TIMEOUT - 5
seconds if the computation hasn't finished. The client can then reach back out with the same query after a while. If the results are ready, the server responds, or it times out again. The result persists in the cache and can be reused for the same query later.This PR has: