enhancement: accept other certificates #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
reviewed
Sep 16, 2024
server/src/cli.rs
Outdated
| .arg( | ||
| Arg::new(Self::OTHER_CERT) | ||
| .long(Self::OTHER_CERT) | ||
| .env("P_OTHER_CERT_PATH") |
There was a problem hiding this comment.
Can we change the variable to P_TRUSTED_CA_CERTS_DIR
env var P_OTHER_CERT_PATH accepts a directory path where user can keep all the certificates intended to be accepted by the server
nikhilsinhaparseable
force-pushed
the
ca-path
branch
from
2c91f18
to
08bd59e
Compare
|
Can you update the doc as well @nikhilsinhaparseable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env var P_OTHER_CERT_PATH accepts a directory path
where user can keep all the certificates intended to be accepted by the server