Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort inferred fields #450

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Sort inferred fields #450

merged 1 commit into from
Jul 3, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Jul 3, 2023

Description

Fix cases where inferred schema breaks arrow file writer invariants.

Similarly to collect_keys, all fields will be sorted by their name.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit 0655f3b into parseablehq:main Jul 3, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
@trueleo trueleo deleted the fix_batched branch July 4, 2023 05:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants