-
-
Notifications
You must be signed in to change notification settings - Fork 173
feat: add process CPU usage cores metric #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pratik50
wants to merge
8
commits into
parseablehq:main
Choose a base branch
from
pratik50:cpu-usage-cores-metric
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
58577a5
feat: add process CPU limit metric
pratik50 d0ed8ef
fix: resolve CPU limit from process cgroup
pratik50 3ba0d8b
fix: detect cgroup v2 CPU limits
pratik50 e86c994
fix: update CPU metrics and remove slow query tracking
pratik50 3f3b694
Merge branch 'main' into cpu
pratik50 33e096e
fix: report CPU limits accurately
pratik50 36b9bc4
feat: add CPU usage cores metric
pratik50 8366f34
Merge remote-tracking branch 'upstream/main' into cpu-usage-cores-metric
pratik50 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
On cgroup v2 errors, fall back to cgroup v1 instead of returning an error.
The v2 branch starts when two conditions are true: a
hierarchy == 0cgroup entry exists, and anycgroup2mount exists. Hybrid hosts meet both conditions. On these hosts, systemd mounts an empty v2 hierarchy at/sys/fs/cgroup/unified, and thecpucontroller stays on v1. That directory has nocpu.max, soread_to_stringfails and the function returnsErr(()). The v1 lookup never runs.The consequence:
cpu_limit_cores()reports0.0even when a real v1 CFS quota exists. A dashboard that computesusage_cores / limit_cores * 100then divides by zero.cgroup_cpu_usage_micros(Lines 148-157) has the same problem withcpu.stat.Use the v2 result only if the v2 control file exists. Otherwise, continue to the v1 path.
🐛 Proposed fix
let directory = cgroup_directory(&cgroup.pathname, &mount.root, &mount.mount_point).ok_or(())?; - let cpu_max = - std::fs::read_to_string(directory.join(CGROUP_V2_CPU_MAX_FILE)).map_err(|_| ())?; - let mut values = cpu_max.split_whitespace(); - return cpu_quota_cores(values.next().ok_or(())?, values.next().ok_or(())?); + if let Ok(cpu_max) = std::fs::read_to_string(directory.join(CGROUP_V2_CPU_MAX_FILE)) { + let mut values = cpu_max.split_whitespace(); + return cpu_quota_cores(values.next().ok_or(())?, values.next().ok_or(())?); + } }Make the same change to the
cpu.statread incgroup_cpu_usage_micros.📝 Committable suggestion
🤖 Prompt for AI Agents