Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dynamic master key by setting Parse Server option masterKey to a function #9582

Open
wants to merge 9 commits into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Feb 1, 2025

Pull Request

Issue

Closes: #9052

Approach

Tasks

  • Add tests

Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (d0b2db6) to head (0d209d1).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9582   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         186      186           
  Lines       14804    14816   +12     
=======================================
+ Hits        13842    13854   +12     
  Misses        962      962           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spec/Middlewares.spec.js Outdated Show resolved Hide resolved
@dblythy dblythy requested a review from a team February 3, 2025 09:46
@mtrezza mtrezza changed the title Feat/dynamic master key feat: Add dynamic master key by setting Parse Server option masterKey to a function Feb 3, 2025
src/Options/index.js Outdated Show resolved Hide resolved
@mtrezza
Copy link
Member

mtrezza commented Feb 9, 2025

The definition check fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic master key and maintenance key
2 participants