fix: Redis 4 does not reconnect after unhandled error in RedisPubSub.js
#9571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Grant <[email protected]>
Thanks for opening this pull request! |
|
Is it possible to add a test case? |
|
@mtrezza I'm not sure how you would add a test case for this fix as it does seem to be largely dependent on the redis connecting timing out and I'm not sure how you'd replicate this during testing. There was no test case on the previous PR (#8706) so I presumed this one wouldn't require a test case either. Happy to be told that I'm wrong though if you can offer some advice / a starting point on where I could add one! |
mtrezza
approved these changes
Feb 10, 2025
4 tasks
|
I haven't looked, but if you say that the test setup currently doesn't allow for Redis connection testing, then let's merge as is. Edit: I have looked and it seems that the Redis server connection is currently not managed as part of the individual tests. |
mtrezza
approved these changes
Feb 10, 2025
mtrezza
changed the title
RedisPubSub.js
mtrezza
requested changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
PR #8706 added empty handlers to
src/Adapters/Cache/RedisCacheAdapter.js.It did not add the empty handlers to RedisPubSub.js, meaning that this issue was closed but not completely fixed when RedisPubSub.js is in use.
Issue
Closes: #8705
Approach
Adds mostly empty event handlers to the Redis client, which is now required for Redis 4.
NB: Please let me know if it would be better to open a new issue for this rather than referring to the original (closed) issue, but I do believe that it is the same issue that hasn't been fixed in a certain area. I've tested the fix in my production environment and it does seem to fix the problem I have been having for a while now.