Skip to content

refactor: Remove module.exports in favor of export default #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration/test/ParseLocalDatastoreTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function runTest(controller) {

describe(`Parse Object Pinning (${controller.name})`, () => {
beforeEach(async () => {
const StorageController = require(controller.file);
const StorageController = require(controller.file).default;
Parse.CoreManager.setAsyncStorage(mockRNStorage);
Parse.CoreManager.setLocalDatastoreController(StorageController);
Parse.CoreManager.setEventEmitter(require('events').EventEmitter);
Expand Down Expand Up @@ -1073,7 +1073,7 @@ function runTest(controller) {

describe(`Parse Query Pinning (${controller.name})`, () => {
beforeEach(async () => {
const StorageController = require(controller.file);
const StorageController = require(controller.file).default;
Parse.CoreManager.setAsyncStorage(mockRNStorage);
Parse.CoreManager.setLocalDatastoreController(StorageController);
Parse.CoreManager.setEventEmitter(require('events').EventEmitter);
Expand Down
9 changes: 5 additions & 4 deletions integration/test/ParseReactNativeTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

const Parse = require('../../react-native');
const { resolvingPromise } = require('../../lib/react-native/promiseUtils');
const CryptoController = require('../../lib/react-native/CryptoController');
const LocalDatastoreController = require('../../lib/react-native/LocalDatastoreController.default');
const StorageController = require('../../lib/react-native/StorageController.default');
const RESTController = require('../../lib/react-native/RESTController');
const CryptoController = require('../../lib/react-native/CryptoController').default;
const LocalDatastoreController =
require('../../lib/react-native/LocalDatastoreController.default').default;
const StorageController = require('../../lib/react-native/StorageController.default').default;
const RESTController = require('../../lib/react-native/RESTController').default;

RESTController._setXHR(require('xmlhttprequest').XMLHttpRequest);

Expand Down
1 change: 0 additions & 1 deletion src/CoreManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -721,5 +721,4 @@ const CoreManager = {
},
};

module.exports = CoreManager;
export default CoreManager;
1 change: 0 additions & 1 deletion src/CryptoController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@ const CryptoController = {
},
};

module.exports = CryptoController;
export default CryptoController;
2 changes: 1 addition & 1 deletion src/EventEmitter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ try {
} catch (_) {
// EventEmitter unavailable
}
module.exports = EventEmitter;

export default EventEmitter;
1 change: 0 additions & 1 deletion src/EventuallyQueue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -355,5 +355,4 @@ const EventuallyQueue = {
},
};

module.exports = EventuallyQueue;
export default EventuallyQueue;
2 changes: 1 addition & 1 deletion src/IndexedDBStorageController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ if (typeof window !== 'undefined' && window.indexedDB) {
// IndexedDB not supported
IndexedDBStorageController = undefined;
}
module.exports = IndexedDBStorageController;

export default IndexedDBStorageController;
1 change: 0 additions & 1 deletion src/InstallationController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,4 @@ const InstallationController = {
},
};

module.exports = InstallationController;
export default InstallationController;
1 change: 0 additions & 1 deletion src/LocalDatastore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,6 @@ const LocalDatastore = {
},
};

module.exports = LocalDatastore;
export default LocalDatastore;

CoreManager.setLocalDatastoreController(LocalDatastoreController);
Expand Down
1 change: 0 additions & 1 deletion src/LocalDatastoreController.default.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,4 @@ const LocalDatastoreController = {
},
};

module.exports = LocalDatastoreController;
export default LocalDatastoreController;
1 change: 0 additions & 1 deletion src/LocalDatastoreController.react-native.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,4 @@ const LocalDatastoreController = {
},
};

module.exports = LocalDatastoreController;
export default LocalDatastoreController;
2 changes: 1 addition & 1 deletion src/LocalDatastoreController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ let LocalDatastoreController: any = DefaultLocalDatastoreController;
if (process.env.PARSE_BUILD === 'react-native') {
LocalDatastoreController = RNLocalDatastoreController;
}
module.exports = LocalDatastoreController;

export default LocalDatastoreController;
1 change: 0 additions & 1 deletion src/OfflineQuery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -591,5 +591,4 @@ const OfflineQuery = {
validateQuery: validateQuery,
};

module.exports = OfflineQuery;
export default OfflineQuery;
1 change: 0 additions & 1 deletion src/ParseInstallation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,5 +286,4 @@ class ParseInstallation<T extends Attributes = Attributes> extends ParseObject<T

ParseObject.registerSubclass('_Installation', ParseInstallation);

module.exports = ParseInstallation;
export default ParseInstallation;
1 change: 0 additions & 1 deletion src/RESTController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -361,5 +361,4 @@ const RESTController = {
},
};

module.exports = RESTController;
export default RESTController;
2 changes: 1 addition & 1 deletion src/Socket.weapp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,5 @@ class SocketWeapp {
wx.closeSocket();
}
}
module.exports = SocketWeapp;

export default SocketWeapp;
1 change: 0 additions & 1 deletion src/Storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,5 +91,4 @@ const Storage = {
},
};

module.exports = Storage;
export default Storage;
1 change: 0 additions & 1 deletion src/StorageController.browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,4 @@ const StorageController = {
},
};

module.exports = StorageController;
export default StorageController;
1 change: 0 additions & 1 deletion src/StorageController.default.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,4 @@ const StorageController = {
},
};

module.exports = StorageController;
export default StorageController;
1 change: 0 additions & 1 deletion src/StorageController.react-native.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,4 @@ const StorageController = {
},
};

module.exports = StorageController;
export default StorageController;
2 changes: 1 addition & 1 deletion src/StorageController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ if (process.env.PARSE_BUILD === 'react-native') {
} else if (process.env.PARSE_BUILD === 'weapp') {
StorageController = WeappStorageController;
}
module.exports = StorageController;

export default StorageController;
1 change: 0 additions & 1 deletion src/StorageController.weapp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,4 @@ const StorageController = {
},
};

module.exports = StorageController;
export default StorageController;
1 change: 0 additions & 1 deletion src/TaskQueue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,4 @@ class TaskQueue {
}
}

module.exports = TaskQueue;
export default TaskQueue;
2 changes: 1 addition & 1 deletion src/WebSocketController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ try {
} catch (_) {
// WebSocket unavailable
}
module.exports = WebSocketController;

export default WebSocketController;
2 changes: 1 addition & 1 deletion src/Xhr.weapp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,5 @@ class XhrWeapp {
});
}
}
module.exports = XhrWeapp;

export default XhrWeapp;
2 changes: 1 addition & 1 deletion src/__tests__/Analytics-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ jest.dontMock('../Analytics');
jest.dontMock('../CoreManager');

const Analytics = require('../Analytics');
const CoreManager = require('../CoreManager');
const CoreManager = require('../CoreManager').default;

const defaultController = CoreManager.getAnalyticsController();

Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/Cloud-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jest.dontMock('../Push');
jest.dontMock('../ParseOp');

const Cloud = require('../Cloud');
const CoreManager = require('../CoreManager');
const CoreManager = require('../CoreManager').default;
const Push = require('../Push');
require('../ParseOp');

Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/CoreManager-test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
jest.dontMock('../CoreManager');

const CoreManager = require('../CoreManager');
const CoreManager = require('../CoreManager').default;

describe('CoreManager', () => {
it('is initialized with default values', () => {
Expand Down
26 changes: 15 additions & 11 deletions src/__tests__/EventuallyQueue-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,26 @@ class MockObject {
return MockSubclass;
}
}
jest.setMock('../ParseObject', MockObject);
jest.setMock('../ParseObject', {
__esModule: true,
default: MockObject,
});

const mockQueryFind = jest.fn();
jest.mock('../ParseQuery', () => {
return jest.fn().mockImplementation(function () {
jest.mock('../ParseQuery', () => ({
__esModule: true,
default: jest.fn().mockImplementation(function () {
this.equalTo = jest.fn();
this.find = mockQueryFind;
});
});
}),
}));
const mockRNStorageInterface = require('./test_helpers/mockRNStorage');
const CoreManager = require('../CoreManager');
const EventuallyQueue = require('../EventuallyQueue');
const CoreManager = require('../CoreManager').default;
const EventuallyQueue = require('../EventuallyQueue').default;
const ParseError = require('../ParseError').default;
const ParseObject = require('../ParseObject');
const RESTController = require('../RESTController');
const Storage = require('../Storage');
const ParseObject = require('../ParseObject').default;
const RESTController = require('../RESTController').default;
const Storage = require('../Storage').default;
const mockXHR = require('./test_helpers/mockXHR');
const flushPromises = require('./test_helpers/flushPromises');

Expand All @@ -65,7 +69,7 @@ describe('EventuallyQueue', () => {
beforeEach(async () => {
jest.clearAllMocks();
CoreManager.setAsyncStorage(mockRNStorageInterface);
CoreManager.setStorageController(require('../StorageController.react-native'));
CoreManager.setStorageController(require('../StorageController.react-native').default);
CoreManager.setRESTController(RESTController);
EventuallyQueue.stopPoll();
await EventuallyQueue.clear();
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/Hooks-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ jest.dontMock('../ParseObject');
jest.dontMock('../RESTController');

const Hooks = require('../ParseHooks');
const CoreManager = require('../CoreManager');
const RESTController = require('../RESTController');
const CoreManager = require('../CoreManager').default;
const RESTController = require('../RESTController').default;

const defaultController = CoreManager.getHooksController();
const { sendRequest } = defaultController;
Expand Down
10 changes: 5 additions & 5 deletions src/__tests__/InstallationController-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jest.mock('../uuid', () => {
return () => value++ + '';
});

const CoreManager = require('../CoreManager');
const ParseInstallation = require('../ParseInstallation');
const InstallationController = require('../InstallationController');
const Storage = require('../Storage');
const CoreManager = require('../CoreManager').default;
const ParseInstallation = require('../ParseInstallation').default;
const InstallationController = require('../InstallationController').default;
const Storage = require('../Storage').default;

CoreManager.setStorageController(require('../StorageController.default'));
CoreManager.setStorageController(require('../StorageController.default').default);

describe('InstallationController', () => {
beforeEach(() => {
Expand Down
6 changes: 3 additions & 3 deletions src/__tests__/LiveQueryClient-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ const mockLocalDatastore = {
};
jest.setMock('../LocalDatastore', mockLocalDatastore);

const CoreManager = require('../CoreManager');
const EventEmitter = require('../EventEmitter');
const CoreManager = require('../CoreManager').default;
const EventEmitter = require('../EventEmitter').default;
const LiveQueryClient = require('../LiveQueryClient').default;
const ParseObject = require('../ParseObject').default;
const ParseQuery = require('../ParseQuery').default;
const WebSocketController = require('../WebSocketController');
const WebSocketController = require('../WebSocketController').default;
const { resolvingPromise } = require('../promiseUtils');
const events = require('events');

Expand Down
36 changes: 21 additions & 15 deletions src/__tests__/LocalDatastore-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,30 +78,36 @@ const mockLocalStorageController = {
getAllContents: jest.fn(),
clear: jest.fn(),
};
jest.setMock('../ParseObject', MockObject);
jest.setMock('../ParseObject', {
__esModule: true,
default: MockObject,
});

const mockQueryFind = jest.fn();
jest.mock('../ParseQuery', () => {
return jest.fn().mockImplementation(function () {
jest.mock('../ParseQuery', () => ({
__esModule: true,
default: jest.fn().mockImplementation(function () {
this.equalTo = jest.fn();
this.containedIn = jest.fn();
this.limit = jest.fn();
this.find = mockQueryFind;
});
});
}),
}));

const CoreManager = require('../CoreManager');
const LocalDatastore = require('../LocalDatastore');
const ParseObject = require('../ParseObject');
const ParseQuery = require('../ParseQuery');
const CoreManager = require('../CoreManager').default;
const LocalDatastore = require('../LocalDatastore').default;
const ParseObject = require('../ParseObject').default;
const ParseQuery = require('../ParseQuery').default;
const ParseUser = require('../ParseUser').default;
const LocalDatastoreController = require('../LocalDatastoreController');
const RNDatastoreController = require('../LocalDatastoreController.react-native');
const BrowserStorageController = require('../StorageController.browser');
const DefaultStorageController = require('../StorageController.default');
const LocalDatastoreController = require('../LocalDatastoreController').default;
const RNDatastoreController = require('../LocalDatastoreController.react-native').default;
const BrowserStorageController = require('../StorageController.browser').default;
const DefaultStorageController = require('../StorageController.default').default;
// Register our mocks
jest.spyOn(CoreManager, 'getParseObject').mockImplementation(() => require('../ParseObject'));
jest.spyOn(CoreManager, 'getParseQuery').mockImplementation(() => require('../ParseQuery'));
jest
.spyOn(CoreManager, 'getParseObject')
.mockImplementation(() => require('../ParseObject').default);
jest.spyOn(CoreManager, 'getParseQuery').mockImplementation(() => require('../ParseQuery').default);

const item1 = new ParseObject('Item');
const item2 = new ParseObject('Item');
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/ObjectStateMutations-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ const mockObject = function (className) {
};
mockObject.registerSubclass = function () {};
jest.setMock('../ParseObject', mockObject);
const CoreManager = require('../CoreManager');
const CoreManager = require('../CoreManager').default;
CoreManager.setParseObject(mockObject);

const ObjectStateMutations = require('../ObjectStateMutations');
const ParseOps = require('../ParseOp');
const TaskQueue = require('../TaskQueue');
const TaskQueue = require('../TaskQueue').default;

describe('ObjectStateMutations', () => {
it('can apply server data', () => {
Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/OfflineQuery-test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
jest.autoMockOff();

const matchesQuery = require('../OfflineQuery').matchesQuery;
const validateQuery = require('../OfflineQuery').validateQuery;
const { matchesQuery, validateQuery } = require('../OfflineQuery').default;
const ParseError = require('../ParseError').default;
const ParseObject = require('../ParseObject').default;
const ParseQuery = require('../ParseQuery').default;
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/Parse-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jest.dontMock('crypto-js/aes');
jest.setMock('../EventuallyQueue', { poll: jest.fn() });

global.indexedDB = require('./test_helpers/mockIndexedDB');
const CoreManager = require('../CoreManager');
const CoreManager = require('../CoreManager').default;
const ParseLiveQuery = require('../ParseLiveQuery').default;
const EventuallyQueue = require('../EventuallyQueue');
const Parse = require('../Parse');
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/ParseACL-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jest.setMock('../ParseRole', mockRole);
const ParseACL = require('../ParseACL').default;
const ParseUser = require('../ParseUser').default;
const ParseRole = require('../ParseRole');
const CoreManager = require('../CoreManager');
const CoreManager = require('../CoreManager').default;
CoreManager.setParseRole(require('../ParseRole'));

describe('ParseACL', () => {
Expand Down
Loading