Skip to content

Error codes for MFA #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2020
Merged

Error codes for MFA #1268

merged 1 commit into from
Dec 4, 2020

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Dec 4, 2020

davimacedo
davimacedo approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@dplewis
Copy link
Member

dplewis commented Dec 4, 2020

@dblythy can you merge from master for the CI?

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1268 (a5d4f7a) into master (17a2f0a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1268   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files          57       57           
  Lines        5405     5407    +2     
  Branches     1204     1204           
=======================================
+ Hits         5404     5406    +2     
  Misses          1        1
Impacted Files Coverage Δ
src/ParseError.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a2f0a...a5d4f7a. Read the comment docs.

dplewis
dplewis approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davimacedo github actions saved 45 seconds on CI time

@dplewis dplewis merged commit f24bd99 into parse-community:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

@dplewis dplewis dplewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dblythy @dplewis @davimacedo