Improve TrieCache size by reducing size_of NodeOwned #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Gheorghe <[email protected]>
AndreiEres
approved these changes
Feb 10, 2025
bkchr
reviewed
Feb 10, 2025
Signed-off-by: Alexandru Gheorghe <[email protected]>
Done, thank you! |
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
lexnv
reviewed
Feb 13, 2025
| /// Returns the number of children. | ||
| pub fn len(&self) -> usize { | ||
| self.0.len() | ||
| } |
There was a problem hiding this comment.
nit: Might be good to have an is_empty for a complete API if we are exposing this to the user (https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty)
lexnv
approved these changes
Feb 13, 2025
bkchr
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeOwned uses static arrays to represent the children of a
NodeOwned::BranchandNodeOwned::NibbledBranch, because the enum's size is the size of largest variant it ends up occupying 752 bytes.The substrate ShareTrieCache ends up keeping a hash map with elements of NodeOwned, so it's size quickly balloons, although most of the children seem to be empty.
The trie cache size benefits greatly from using a dynamic array instead of static one: paritytech/polkadot-sdk#6131 (comment), using westend-asset-hub, we can see a ~4 times reduction in memory size for the TrieCache.
Fixes: paritytech/polkadot-sdk#7386