Address some issues around tx mortality#2025
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it a runtime error if you explicitly set an extrinsic to be
.mortal(..)when providing params to it, but then are constructing it offline which prevents this from working. Previously we'd turn the extrinsic into an immortal one.Expose
mortal_from_uncheckedin theDefaultExtrinsicParamsBuilderto make it a little more ergonomic to set the relevant mortality params when constructing eg an offline extrinsic. Previously You'd have to do:Clarify the docs on these functions to make it clear that you can't use
mortal()with offline extrinsics.Actually construct mortal transactions by default. I think this was the intended behaviour, but it may have been accidentally broken because the default Params actually led to immortal transactions.
This led to uncovering an issue decoding Eras, and so now there is a proper implementation of EncodeAsType and DecodeAsType for it.
Closes #2024