Keep codec attrs even when Encode/Decode not used#2023
Merged
Conversation
jsdw
force-pushed
the
jsdw-keep-codec-attrs
branch
from
June 16, 2025 14:48
9fc7b8c to
fc84f89
Compare
lexnv
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scale-typegeninserts some__ignorefields when it needs to represent some generic type that isn't used in a field, so that it can add aPhantomData<T>to make this valid.Perhaps (probably, I think) wrongly,
scale-typegenonly adds#[codec(skip)]ifinsert_codec_attributes: true. So, let's just always set this to true for now to avoid issues decoding things into structs with__ignorefields. This also adds#[codec(index = N)]attrs, but these are harmless anyway.The failing example in #2021 no longer fails with this change.
Closes #2021