Skip to content

Remove now-unnecessary ensure_unique_type_paths invocation#2018

Closed
jsdw wants to merge 2 commits into
masterfrom
jsdw-ensure-unique-types-tidyup
Closed

Remove now-unnecessary ensure_unique_type_paths invocation#2018
jsdw wants to merge 2 commits into
masterfrom
jsdw-ensure-unique-types-tidyup

Conversation

@jsdw

@jsdw jsdw commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

We now call this manually in the macro/CLI prior to checking derives/substitutes, so no need to call it again here.

@jsdw jsdw requested a review from a team June 3, 2025 14:09
@jsdw

jsdw commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

Actually, a test fails:

    thread 'full_client::codegen::documentation::check_documentation' panicked at testing/integration-tests/src/full_client/codegen/documentation.rs:63:10:
    API generation must be valid: TypeGeneration(DuplicateTypePath("pallet_referenda::pallet::Event"))

This implies that we do actually point directly to the RuntimeGenerator somewhere, or else have missed something. This isn't a very important PR so I'll probably close it for now.

@jsdw jsdw closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant